Page 2 of 2 FirstFirst 12
Results 26 to 37 of 37

Thread: Trying to undestand how to identify a division

  1. #26

    Join Date
    09-03-12
    Posts
    99
    ahahahahahahah sorry Nick


    I did it but then I have problems inserting the other code because if I replace the existing one it deletes me two more lines. this is the part that I have not yet fully understood, in this case what should be done?


    00646636 . 81C4 00020000 ADD ESP,200
    0064663C C2 1000 RETN 10
    0064663F 33DB XOR EBX,EBX
    00646641 3AC3 CMP AL,BL
    00646643 0F85 8F000000 JNZ cm0102.006466D8
    00646649 . 8B8424 1C02000>MOV EAX,DWORD PTR SS:[ESP+21C]

    how can i add new line ( nop i suppose ) after the retn 10?

  2. #27

    Join Date
    18-07-15
    Posts
    795
    @clipeus: that's what makes it so tricky - you can't add new lines - as it would break other lines (the JMP,CALL,etc commands jump a certain number of bytes - so if you add more bytes in between it breaks all of them).

    Patching Serie B to have proper playoffs is more tricky than I thought it would be! Never tried doing something like this so probably going about it the wrong way. For now I'm trying to leverage Serie C1's playoff code in Serie B and then just adjust slightly for the difference. Might be the wrong approach but here's the patches I've got so far:
    Code:
    CPU Disasm
    Address   Hex dump          Command                                  Comments
    00645875      6A 08         PUSH 8                              <--- changed
    00645877  |.  889E EE000000 MOV BYTE PTR DS:[ESI+0EE],BL
    0064587D  |.  8846 44       MOV BYTE PTR DS:[ESI+44],AL
    00645880  |.  8946 30       MOV DWORD PTR DS:[ESI+30],EAX
    00645883      C746 2C 02000 MOV DWORD PTR DS:[ESI+2C],2         <---- changed (below code from C1 set up - need that +0C function later)
    0064588A      E8 B7F52F00   CALL 00944E46
    0064588F      83C4 04       ADD ESP,4
    00645892      89F1          MOV ECX,ESI
    00645894      8946 0C       MOV DWORD PTR DS:[ESI+0C],EAX
    00645897      E8 D45E0000   CALL 0064B770
    0064589C      EB 2B         JMP SHORT 006458C9
    0064589E      90            NOP
    0064589F      90            NOP
    006458A0      90            NOP
    006458A1      90            NOP
    006458A2      90            NOP
    006458A3      90            NOP
    
    CPU Disasm
    Address   Hex dump          Command                                  Comments
    0064663F     \E9 704D0000   JMP 0064B3B4
    00646644      90            NOP
    00646645      90            NOP
    00646646      90            NOP
    00646647      90            NOP
    00646648      90            NOP
    ^ Jump to C1 play-off fixtures
    
    CPU Disasm
    Address   Hex dump          Command                                  Comments
    00646951      C786 BE000000 MOV DWORD PTR DS:[ESI+0BE],3020602
    0064695B      5E            POP ESI
    0064695C      5B            POP EBX
    0064695D      C3            RETN
    ^ set up the number of playoffs, promotions. Mainly affects the lines shown in the league.
    
    CPU Disasm
    Address   Hex dump          Command                                  Comments
    00646B20     /E9 BB4E0000   JMP 0064B9E0
    00646B25     |90            NOP
    ^ Jump from Serie b play off code to Serie c play off code
    But even all this does not get it quite there yet!

  3. The Following User Says Thank You to Nick+Co For This Useful Post:


  4. #28

    Join Date
    09-03-12
    Posts
    99
    again like the last two day thank you

    it's really really difficult for who like me doesn know anything about codes...
    i only look at the block and try to understand which are similiar..

    i'll try to understand the patch you post!! ( it will be easier with your comments )

    thanks again
    Marco

  5. #29

    Join Date
    09-03-12
    Posts
    99
    I will have done something wrong .. surely the dates are completely wrong ..

    also the fixtures
    completely mixed
    really really hard....


    I tried to add that patch by adding nop when it could serve and rewriting the lines that olly deleted

    mmmmmmmmh i don't understand why the date are messed up
    Last edited by clipeus; 21-06-20 at 12:04 PM.

  6. #30

    Join Date
    21-02-19
    Posts
    48
    @Nick+Co - I used the coding you had discussed in this thread to try and get the playoffs working in the English National League (as there is a block of coding in the fixtures for this). Have managed to get it to display on the fixture schedule in game okay, however the fixtures never get drawn/played out. There are three rounds in the playoffs for the ENL (so 6 teams), getting this working would then allow you to patch Serie B onto this to create the 6 team playoff that Marco has mentioned.

    Not sure why I can't get the playoffs to work - but I have noticed that the coding for the switch table that is used in all other leagues is not there in the ENL - could this be causing the issue?

  7. #31

    Join Date
    21-02-19
    Posts
    48
    If anyone wants to have a look through it, these are the offsets I've changed;

    0056EE1D |. C786 BE000000 >MOV DWORD PTR DS:[ESI+BE],3000602 (This was 3002. Have added 6 playoff places as there are 3 rounds in the playoff fixture coding)

    0056DBC5 . 6A 04 PUSH 4 - This is same as Champ/Lge 1/Lge 2
    0056DBC7 . 66:C786 E20000>MOV WORD PTR DS:[ESI+E2],3E8
    0056DBD0 . 66:C786 E40000>MOV WORD PTR DS:[ESI+E4],258
    0056DBD9 . 8846 44 MOV BYTE PTR DS:[ESI+44],AL
    0056DBDC . 8946 30 MOV DWORD PTR DS:[ESI+30],EAX
    0056DBDF . C746 2C 010000>MOV DWORD PTR DS:[ESI+2C],1 - Same as Champ/Lge 1/Lge 2
    0056DBE6 . E8 5B723D00 CALL cm0102.00944E46 - Added in following lines as per Nick+Co instructions re Serie B
    0056DBEB . 83C4 04 ADD ESP,4
    0056DBEE . 8BCE MOV ECX,ESI
    0056DBF0 . 8946 0C MOV DWORD PTR DS:[ESI+C],EAX
    0056DBF3 . E8 E8110000 CALL cm0102.0056EDE0
    0056DBF8 . EB 24 JMP SHORT cm0102.0056DC1E - As ENL has its own playoff fixtures I've put the JMP to these rather than to another league as Nick did on Serie B

    0056DEE1 . E9 B10B0000 JMP cm0102.0056EA96 - This originally went to 0056EA97, which was a Call instruction, but in the other English leagues this JMP points to the line directly above the Call instruction, hence I changed it here.

    In the ENL the fixtures are a tad all over the place, I think done when the league was increased from 22 teams to 24. So there is a JMP after the 15th fixture that goes to the 16th fixture and then another after the 41st fixture that goes back up the coding to the 42nd fixture (which is actually listed after the 15th fixture (this is where I think the switch table used to be).


    0056EA17 .^E9 44F9FFFF JMP cm0102.0056E360 - this is at end of the league fixtures, which is actually game number 42. It goes to the coding for games 43-46. Reckoning that the code after game 46 needs to "connect" to the code for the playoffs (as it runs through in the other leagues), I have added the below line in (this may be completely wrong, or possibly is the right thinking just been placed in the wrong spot)

    0056E425 . E9 F2050000 JMP cm0102.0056EA1C


    All of the above changes create 6 playoff places (3rd-8th) and if you go to the fixture schedule for the league you can see that the dates are all scheduled; Semi-Final - Final - Grand Final.
    However, the Semi-Final draw never takes place, so the fixtures never happen.
    Have spent too long staring at Olly today and cannot seem to see why the fixtures don't take place. When the season updates in July none of the English Leagues update; they are all stuck as they finished on final day of the playoffs (because ENL hasn't sorted it's promoted teams).

  8. #32

    Join Date
    09-03-12
    Posts
    99
    you see the playoff rounds, but at the end of the season they don't start. in the ranking do you also see the lines that delimit the teams qualified for the playoffs? sorry if these are stupid questions

  9. #33

    Join Date
    21-02-19
    Posts
    48
    Yeah, both of those do occur - see screen shots below

    League Schedule - https://ibb.co/zSj9b8Y


    League Table - https://ibb.co/6BbJ7L3

  10. #34

    Join Date
    09-03-12
    Posts
    99
    really strange... also if you continue to the next season? no playoff ?

  11. #35

    Join Date
    21-02-19
    Posts
    48
    No, no playoffs take place, that's the problem. It continues to the next season but the only league that updates is the National League North, all other leagues in England get stuck in limbo with tables displaying the finish to last season.

  12. #36

    Join Date
    09-03-12
    Posts
    99
    oh.... this is nice... maybe should be better trying with another league.. only first and second division.. in this way maybe it should be easier to find why don't update the first league...

  13. #37

    Join Date
    09-03-12
    Posts
    99
    thinking about it, maybe you should delay the generation of other schedules or something similar, because if you have added the playoffs, the upper league always adopts the old way, because maybe it looks for the results at that date, maybe you should change the date from which it draws data to create schedules

Page 2 of 2 FirstFirst 12

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •